From 0807e9e253f585e72432f77ed5b2b7aba7a86eaf Mon Sep 17 00:00:00 2001 From: henderkes Date: Sun, 24 May 2026 20:54:44 +0700 Subject: [PATCH] watcher: drop ldflags from compile-only invocation The shell invocation runs `$CXX -c` to compile watcher-c.cpp to a .o, which never links. Passing linker flags to a compile-only step is either ignored or, with some flags, an error. Drop them. --- src/Package/Library/watcher.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Package/Library/watcher.php b/src/Package/Library/watcher.php index 56f93d93..34f8eb9a 100644 --- a/src/Package/Library/watcher.php +++ b/src/Package/Library/watcher.php @@ -20,9 +20,8 @@ class watcher extends LibraryPackage if (stripos($cflags, '-fpic') === false) { $cflags .= ' -fPIC'; } - $ldflags = $this->getLibExtraLdFlags() ? ' ' . $this->getLibExtraLdFlags() : ''; shell()->cd("{$this->getSourceDir()}/watcher-c") - ->exec(getenv('CXX') . " -c -o libwatcher-c.o ./src/watcher-c.cpp -I ./include -I ../include -std=c++17 -Wall -Wextra {$cflags}{$ldflags}") + ->exec(getenv('CXX') . " -c -o libwatcher-c.o ./src/watcher-c.cpp -I ./include -I ../include -std=c++17 -Wall -Wextra {$cflags}") ->exec(getenv('AR') . ' rcs libwatcher-c.a libwatcher-c.o'); copy("{$this->getSourceDir()}/watcher-c/libwatcher-c.a", "{$this->getLibDir()}/libwatcher-c.a");