From 1a87ce41944f1e897ca98eaeb5b2683db53c6fbc Mon Sep 17 00:00:00 2001 From: Jerry Ma Date: Thu, 25 Apr 2024 15:55:08 +0800 Subject: [PATCH] Fix windows nghttp2 dynamic linking bug (#422) * fix windows nghttp2 dynamic linking bug * add tests for fixing windows nghttp2 dynamic linking bug --- src/SPC/builder/windows/library/nghttp2.php | 2 ++ src/globals/test-extensions.php | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/SPC/builder/windows/library/nghttp2.php b/src/SPC/builder/windows/library/nghttp2.php index 85332202..7e6e999d 100644 --- a/src/SPC/builder/windows/library/nghttp2.php +++ b/src/SPC/builder/windows/library/nghttp2.php @@ -25,6 +25,8 @@ class nghttp2 extends WindowsLibraryBase '-DCMAKE_BUILD_TYPE=Release ' . '-DENABLE_SHARED_LIB=OFF ' . '-DENABLE_STATIC_LIB=ON ' . + '-DBUILD_STATIC_LIBS=ON ' . + '-DBUILD_SHARED_LIBS=OFF ' . '-DENABLE_STATIC_CRT=ON ' . '-DENABLE_LIB_ONLY=ON ' . '-DCMAKE_INSTALL_PREFIX=' . BUILD_ROOT_PATH . ' ' diff --git a/src/globals/test-extensions.php b/src/globals/test-extensions.php index 3aae34b1..4c91a420 100644 --- a/src/globals/test-extensions.php +++ b/src/globals/test-extensions.php @@ -14,7 +14,7 @@ declare(strict_types=1); // If you want to test your added extensions and libs, add below (comma separated, example `bcmath,openssl`). $extensions = match (PHP_OS_FAMILY) { 'Linux', 'Darwin' => 'intl,posix', - 'Windows' => 'mbstring,pdo_sqlite,mbregex', + 'Windows' => 'mbstring,pdo_sqlite,mbregex,curl', }; // If you want to test lib-suggests feature with extension, add them below (comma separated, example `libwebp,libavif`).