Fix php74 upx bug (#450)

* fix php74 cannot compile with no-strip or with-upx-pack (including lint some code)

* use captainhook installer instead of plugin composer

* use captainhook installer instead of plugin composer

* add [no build test] flag

* update actions/cache version [no build test]

* test update actions/cache version

* test update actions/cache version

* test update actions/cache version

src/SPC/util/GlobalEnvManager.php

@@ -51,7 +51,7 @@ class GlobalEnvManager
 
         // Init system-specific env
         match (PHP_OS_FAMILY) {
-            'Windows' => self::initWindowsEnv($builder),
+            'Windows' => self::initWindowsEnv(),
             'Darwin' => self::initDarwinEnv($builder),
             'Linux' => self::initLinuxEnv($builder),
             'BSD' => 'TODO',
@@ -59,7 +59,7 @@ class GlobalEnvManager
         };
     }
 
-    private static function initWindowsEnv(BuilderBase $builder): void
+    private static function initWindowsEnv(): void
     {
         // Windows need php-sdk binary tools
         self::initIfNotExists('PHP_SDK_PATH', WORKING_DIR . DIRECTORY_SEPARATOR . 'php-sdk-binary-tools');
@@ -69,7 +69,7 @@ class GlobalEnvManager
     private static function initLinuxEnv(BuilderBase $builder): void
     {
         // Init C Compiler and C++ Compiler (alpine)
-        if (\SPC\builder\linux\SystemUtil::isMuslDist()) {
+        if (LinuxSystemUtil::isMuslDist()) {
             self::initIfNotExists('CC', 'gcc');
             self::initIfNotExists('CXX', 'g++');
             self::initIfNotExists('AR', 'ar');

src/SPC/util/LicenseDumper.php

@@ -10,6 +10,9 @@ use SPC\exception\WrongUsageException;
 use SPC\store\Config;
 use SPC\store\FileSystem;
 
+/**
+ * License dumper, dump source license files to target directory
+ */
 class LicenseDumper
 {
     private array $exts = [];
@@ -37,6 +40,10 @@ class LicenseDumper
     }
 
     /**
+     * Dump source licenses to target directory
+     *
+     * @param  string              $target_dir Target directory
+     * @return bool                Success or not
      * @throws WrongUsageException
      * @throws FileSystemException
      * @throws RuntimeException
@@ -55,20 +62,29 @@ class LicenseDumper
 
             $source_name = Config::getExt($ext, 'source');
             foreach ($this->getSourceLicenses($source_name) as $index => $license) {
-                file_put_contents("{$target_dir}/ext_{$ext}_{$index}.txt", $license);
+                $result = file_put_contents("{$target_dir}/ext_{$ext}_{$index}.txt", $license);
+                if ($result === false) {
+                    return false;
+                }
             }
         }
 
         foreach ($this->libs as $lib) {
             $source_name = Config::getLib($lib, 'source');
             foreach ($this->getSourceLicenses($source_name) as $index => $license) {
-                file_put_contents("{$target_dir}/lib_{$lib}_{$index}.txt", $license);
+                $result = file_put_contents("{$target_dir}/lib_{$lib}_{$index}.txt", $license);
+                if ($result === false) {
+                    return false;
+                }
             }
         }
 
         foreach ($this->sources as $source) {
             foreach ($this->getSourceLicenses($source) as $index => $license) {
-                file_put_contents("{$target_dir}/src_{$source}_{$index}.txt", $license);
+                $result = file_put_contents("{$target_dir}/src_{$source}_{$index}.txt", $license);
+                if ($result === false) {
+                    return false;
+                }
             }
         }
         return true;

src/SPC/util/Patcher.php

@@ -1,38 +0,0 @@
-<?php
-
-declare(strict_types=1);
-
-namespace SPC\util;
-
-use SPC\exception\FileSystemException;
-use SPC\exception\RuntimeException;
-use SPC\store\FileSystem;
-
-class Patcher
-{
-    /**
-     * @throws FileSystemException
-     * @throws RuntimeException
-     */
-    public static function patchLinuxConfigHeader(string $libc): void
-    {
-        switch ($libc) {
-            case 'musl_wrapper':
-                // bad checks
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_STRLCPY 1$/m', '');
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_STRLCAT 1$/m', '');
-                // no break
-            case 'musl':
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_FUNC_ATTRIBUTE_IFUNC 1$/m', '');
-                break;
-            case 'glibc':
-                // avoid lcrypt dependency
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_CRYPT 1$/m', '');
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_CRYPT_R 1$/m', '');
-                FileSystem::replaceFileRegex(SOURCE_PATH . '/php-src/main/php_config.h', '/^#define HAVE_CRYPT_H 1$/m', '');
-                break;
-            default:
-                throw new RuntimeException('not implemented');
-        }
-    }
-}

src/SPC/util/UnixShell.php

@@ -15,6 +15,9 @@ class UnixShell
 
     private array $env = [];
 
+    /**
+     * @throws RuntimeException
+     */
     public function __construct(?bool $debug = null)
     {
         if (PHP_OS_FAMILY === 'Windows') {

src/SPC/util/WindowsCmd.php

@@ -15,6 +15,9 @@ class WindowsCmd
 
     private array $env = [];
 
+    /**
+     * @throws RuntimeException
+     */
     public function __construct(?bool $debug = null)
     {
         if (PHP_OS_FAMILY !== 'Windows') {