From 5a98bd6656cd0b54e71cdca36df37706ecbb3b73 Mon Sep 17 00:00:00 2001 From: crazywhalecc Date: Sun, 24 Dec 2023 13:07:51 +0800 Subject: [PATCH] dir separator and typo fix [skip ci] --- src/SPC/doctor/item/WindowsToolCheckList.php | 5 +++-- src/globals/defines.php | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/SPC/doctor/item/WindowsToolCheckList.php b/src/SPC/doctor/item/WindowsToolCheckList.php index 70d6287d..73092233 100644 --- a/src/SPC/doctor/item/WindowsToolCheckList.php +++ b/src/SPC/doctor/item/WindowsToolCheckList.php @@ -16,12 +16,13 @@ class WindowsToolCheckList public function checkGit(): ?CheckResult { if (SystemUtil::findCommand('git.exe') === null) { - return CheckResult::fail('Git not installed, see https://static-php.dev/en/guide/windows-setup.html'); + return CheckResult::fail('Git not installed, please install git for windows manually, see: https://git-scm.com/download/win'); + // return CheckResult::fail('Git not installed, see https://static-php.dev/en/guide/windows-setup.html'); } return CheckResult::ok(); } - #[AsCheckItem('if php-sdk-binary-tools2 are downloaded', limit_os: 'Windows', level: 998)] + #[AsCheckItem('if php-sdk-binary-tools are downloaded', limit_os: 'Windows', level: 998)] public function checkSDK(): ?CheckResult { if (!file_exists(PHP_SDK_PATH . DIRECTORY_SEPARATOR . 'phpsdk-starter.bat')) { diff --git a/src/globals/defines.php b/src/globals/defines.php index dc8281be..2e5c0b62 100644 --- a/src/globals/defines.php +++ b/src/globals/defines.php @@ -23,7 +23,7 @@ define('SEPARATED_PATH', [ ]); if (PHP_OS_FAMILY === 'Windows') { - define('PHP_SDK_PATH', is_string($a = getenv('PHP_SDK_PATH')) ? $a : (WORKING_DIR . '/php-sdk-binary-tools')); + define('PHP_SDK_PATH', is_string($a = getenv('PHP_SDK_PATH')) ? $a : (WORKING_DIR . DIRECTORY_SEPARATOR . 'php-sdk-binary-tools')); } // dangerous command