From 5db23e1db705b75ce88ae88b53bbbf1a0d5259d0 Mon Sep 17 00:00:00 2001 From: crazywhalecc Date: Wed, 1 Nov 2023 01:49:48 +0800 Subject: [PATCH] let sanity check can be overwritten --- src/SPC/builder/Extension.php | 3 ++- src/SPC/builder/traits/UnixBuilderTrait.php | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/SPC/builder/Extension.php b/src/SPC/builder/Extension.php index 5d9f2e6b..21f0f574 100644 --- a/src/SPC/builder/Extension.php +++ b/src/SPC/builder/Extension.php @@ -166,10 +166,11 @@ class Extension /** * Run compile check if build target is cli * If you need to run some check, overwrite this or add your assert in src/globals/tests/{extension_name}.php + * If check failed, throw RuntimeException * * @throws RuntimeException */ - public function runCheck(): void + public function runCliCheck(): void { [$ret] = shell()->execWithResult(BUILD_ROOT_PATH . '/bin/php --ri "' . $this->getDistName() . '"', false); if ($ret !== 0) { diff --git a/src/SPC/builder/traits/UnixBuilderTrait.php b/src/SPC/builder/traits/UnixBuilderTrait.php index d698c730..3fead06f 100644 --- a/src/SPC/builder/traits/UnixBuilderTrait.php +++ b/src/SPC/builder/traits/UnixBuilderTrait.php @@ -66,7 +66,7 @@ trait UnixBuilderTrait foreach ($this->exts as $ext) { logger()->debug('testing ext: ' . $ext->getName()); - $ext->runCheck(); + $ext->runCliCheck(); } }