From 6d58d53f7dcab626ae2b675113bac2cf7a60f394 Mon Sep 17 00:00:00 2001 From: m-this <52073029+m-this@users.noreply.github.com> Date: Fri, 10 Jul 2026 10:52:14 +0200 Subject: [PATCH] fix(imagemagick): build the VisualMagick tree under source/ on windows - C:\im was outside the project so bin/spc reset could not clean it - with the command line limit fixed a short base path is no longer needed; keep SPC_IMAGEMAGICK_BUILD_DIR as an override --- src/Package/Library/imagemagick.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Package/Library/imagemagick.php b/src/Package/Library/imagemagick.php index 2647aae8..7e660499 100644 --- a/src/Package/Library/imagemagick.php +++ b/src/Package/Library/imagemagick.php @@ -25,13 +25,13 @@ class imagemagick * msbuild. The resulting CORE_RL_*.lib static libraries + MagickWand/MagickCore headers are * installed into the build root for ext-imagick to link. * - * A short working directory is used (VisualMagick's tree is deeply nested and otherwise exceeds - * MAX_PATH); override with SPC_IMAGEMAGICK_BUILD_DIR. + * The VisualMagick tree lives under source/ so bin/spc reset cleans it up like everything + * else; override the location with SPC_IMAGEMAGICK_BUILD_DIR. */ #[BuildFor('Windows')] public function buildWin(LibraryPackage $lib): void { - $work = getenv('SPC_IMAGEMAGICK_BUILD_DIR') ?: 'C:\im'; + $work = getenv('SPC_IMAGEMAGICK_BUILD_DIR') ?: SOURCE_PATH . '\imagemagick-win'; $configure_release = '2026.05.30.2033'; $configure_url = "https://github.com/ImageMagick/Configure/releases/download/{$configure_release}/Configure.Release.x64.exe";