crazywhalecc/static-php-cli
1
0
Fork 0
mirror of https://github.com/crazywhalecc/static-php-cli.git synced 2026-07-09 01:45:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

docs(frankenphp): link golang/go#80290 so the -mthreads workaround can be removed later

Browse Source
This commit is contained in:
mathis
2026-07-08 03:59:20 +02:00
parent 5a5c784c4f
commit 83ce54b62b
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/Package/Target/php/frankenphp.php
View File

@@ -381,9 +381,12 @@ trait frankenphp
/** /**
* Return the [CC, CXX] cgo should use to build FrankenPHP on Windows. * Return the [CC, CXX] cgo should use to build FrankenPHP on Windows.
* *
* Go passes the MinGW-only `-mthreads` flag to the C compiler for cgo builds * Go passes the MinGW-only `-mthreads` flag to the C compiler for cgo builds;
* (golang/go#16932); Clang >= 20 rejects it for the MSVC target. When it does, * Clang >= 20 rejects it for the MSVC target. When it does, wrap Clang with
* wrap Clang with a tiny .bat that strips the flag before forwarding. * a tiny .bat that strips the flag before forwarding.
*
* Workaround for https://github.com/golang/go/issues/80290, remove once Go
* stops passing the flag.
* *
* @return array{0: string, 1: string} * @return array{0: string, 1: string}
*/ */
@@ -398,7 +401,7 @@ trait frankenphp
return ['clang.exe', 'clang++.exe']; return ['clang.exe', 'clang++.exe'];
} }
logger()->info('Clang rejects -mthreads; wrapping it to strip the flag (golang/go#16932)'); logger()->info('Clang rejects -mthreads; wrapping it to strip the flag (golang/go#80290)');
$dir = dirname($clang); $dir = dirname($clang);
$cc = $package->getSourceDir() . '\cc-nothreads.bat'; $cc = $package->getSourceDir() . '\cc-nothreads.bat';
$cxx = $package->getSourceDir() . '\cxx-nothreads.bat'; $cxx = $package->getSourceDir() . '\cxx-nothreads.bat';