force minimum version 3.12 for cmake policies in freetype, only when cmake >= 4

This commit is contained in:
DubbleClick 2025-06-04 21:18:44 +07:00
parent dabf52511f
commit ef7ebdfd1f
4 changed files with 34 additions and 15 deletions

View File

@ -18,6 +18,10 @@ trait freetype
*/ */
protected function build(): void protected function build(): void
{ {
$extra = '';
if (version_compare(get_cmake_version(), '4.0.0', '>=')) {
$extra .= '-DCMAKE_POLICY_VERSION_MINIMUM=3.12 ';
}
$extra_libs = $this->builder->getLib('libpng') ? '-DFT_DISABLE_PNG=OFF ' : '-DFT_DISABLE_PNG=ON '; $extra_libs = $this->builder->getLib('libpng') ? '-DFT_DISABLE_PNG=OFF ' : '-DFT_DISABLE_PNG=ON ';
$extra_libs .= $this->builder->getLib('bzip2') ? '-DFT_DISABLE_BZIP2=OFF ' : '-DFT_DISABLE_BZIP2=ON '; $extra_libs .= $this->builder->getLib('bzip2') ? '-DFT_DISABLE_BZIP2=OFF ' : '-DFT_DISABLE_BZIP2=ON ';
$extra_libs .= $this->builder->getLib('brotli') ? '-DFT_DISABLE_BROTLI=OFF ' : '-DFT_DISABLE_BROTLI=ON '; $extra_libs .= $this->builder->getLib('brotli') ? '-DFT_DISABLE_BROTLI=OFF ' : '-DFT_DISABLE_BROTLI=ON ';
@ -25,7 +29,7 @@ trait freetype
shell()->cd($this->source_dir . '/build') shell()->cd($this->source_dir . '/build')
->setEnv(['CFLAGS' => $this->getLibExtraCFlags(), 'LDFLAGS' => $this->getLibExtraLdFlags(), 'LIBS' => $this->getLibExtraLibs()]) ->setEnv(['CFLAGS' => $this->getLibExtraCFlags(), 'LDFLAGS' => $this->getLibExtraLdFlags(), 'LIBS' => $this->getLibExtraLibs()])
->execWithEnv( ->execWithEnv(
"cmake {$this->builder->makeCmakeArgs()} -DFT_DISABLE_HARFBUZZ=ON -DCMAKE_POLICY_VERSION_MINIMUM=3.5 " . "cmake {$this->builder->makeCmakeArgs()} -DFT_DISABLE_HARFBUZZ=ON {$extra}" .
'-DBUILD_SHARED_LIBS=OFF ' . '-DBUILD_SHARED_LIBS=OFF ' .
"{$extra_libs}.." "{$extra_libs}.."
) )

View File

@ -87,17 +87,14 @@ class LinuxToolCheckList
#[AsCheckItem('if cmake version >= 3.18', limit_os: 'Linux')] #[AsCheckItem('if cmake version >= 3.18', limit_os: 'Linux')]
public function checkCMakeVersion(): ?CheckResult public function checkCMakeVersion(): ?CheckResult
{ {
$check_cmd = 'cmake --version'; $ver = get_cmake_version();
$pattern = '/cmake version (.*)/m'; if ($ver === null) {
$out = shell()->execWithResult($check_cmd, false)[1][0]; return CheckResult::fail('Failed to get cmake version');
if (preg_match($pattern, $out, $match)) {
$ver = $match[1];
if (version_compare($ver, '3.18.0') <= 0) {
return CheckResult::fail('cmake version is too low (' . $ver . '), please update it manually!');
}
return CheckResult::ok($match[1]);
} }
return CheckResult::fail('Failed to get cmake version'); if (version_compare($ver, '3.18.0') < 0) {
return CheckResult::fail('cmake version is too low (' . $ver . '), please update it manually!');
}
return CheckResult::ok($ver);
} }
/** @noinspection PhpUnused */ /** @noinspection PhpUnused */

View File

@ -192,3 +192,21 @@ function f_putenv(string $env): bool
logger()->debug('Setting env: ' . $env); logger()->debug('Setting env: ' . $env);
return putenv($env); return putenv($env);
} }
/**
* Get the installed CMake version
*
* @return string|null The CMake version or null if it couldn't be determined
*/
function get_cmake_version(): ?string
{
try {
[,$output] = shell()->execWithResult('cmake --version', false);
if (preg_match('/cmake version ([\d.]+)/i', $output[0], $matches)) {
return $matches[1];
}
} catch (Exception $e) {
logger()->warning('Failed to get CMake version: ' . $e->getMessage());
}
return null;
}

View File

@ -13,9 +13,9 @@ declare(strict_types=1);
// test php version (8.1 ~ 8.4 available, multiple for matrix) // test php version (8.1 ~ 8.4 available, multiple for matrix)
$test_php_version = [ $test_php_version = [
// '8.1', '8.1',
// '8.2', '8.2',
// '8.3', '8.3',
'8.4', '8.4',
]; ];
@ -23,7 +23,7 @@ $test_php_version = [
$test_os = [ $test_os = [
// 'macos-13', // 'macos-13',
// 'macos-14', // 'macos-14',
'macos-15', // 'macos-15',
'ubuntu-latest', 'ubuntu-latest',
// 'ubuntu-22.04', // 'ubuntu-22.04',
// 'ubuntu-24.04', // 'ubuntu-24.04',