From fb7730989c08119326f23ea2d338042f782860c4 Mon Sep 17 00:00:00 2001 From: Marc Date: Thu, 9 Apr 2026 14:00:10 +0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Marc --- src/SPC/builder/extension/xlswriter.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/SPC/builder/extension/xlswriter.php b/src/SPC/builder/extension/xlswriter.php index cb5c82bc..8ef826d0 100644 --- a/src/SPC/builder/extension/xlswriter.php +++ b/src/SPC/builder/extension/xlswriter.php @@ -30,7 +30,7 @@ class xlswriter extends Extension { $patched = parent::patchBeforeMake(); - // Bundled minizip uses K&R C function declarations rejected by C23 (default on macOS with Xcode 16+) + // Remove when https://github.com/viest/php-ext-xlswriter/pull/560 is merged if (PHP_OS_FAMILY !== 'Windows') { GlobalEnvManager::putenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS=' . getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS') . ' -std=gnu17'); $patched = true; @@ -49,6 +49,7 @@ class xlswriter extends Extension return $patched; } + // Remove when https://github.com/viest/php-ext-xlswriter/pull/560 is merged protected function getExtraEnv(): array { return ['CFLAGS' => '-std=gnu17'];