rename COMPILER_EXTRA to SPC_COMPILER_EXTRA

.gitignore

@@ -36,7 +36,6 @@ packlib_files.txt
 !/bin/setup-runtime*
 !/bin/spc-alpine-docker
 !/bin/php-cs-fixer-wrapper
-!/bin/build-static-frankenphp
 
 # exclude windows build tools
 /php-sdk-binary-tools/

bin/build-static-frankenphp

@@ -1,158 +0,0 @@
-#!/usr/bin/env bash
-
-# This file is using docker to run commands
-set -e
-
-# Detect docker can run
-if ! which docker >/dev/null; then
-  echo "Docker is not installed, please install docker first !"
-  exit 1
-fi
-DOCKER_EXECUTABLE="docker"
-# shellcheck disable=SC2046
-if [ $(id -u) -ne 0 ]; then
-    if ! docker info > /dev/null 2>&1; then
-        if [ "$SPC_USE_SUDO" != "yes" ]; then
-            echo "Docker command requires sudo"
-            # shellcheck disable=SC2039
-            echo -n 'To use sudo to run docker, run "export SPC_USE_SUDO=yes" and run command again'
-            exit 1
-        fi
-        DOCKER_EXECUTABLE="sudo docker"
-    fi
-fi
-
-
-
-# to check if qemu-docker run
-if [ "$SPC_USE_ARCH" = "" ]; then
-    SPC_USE_ARCH=current
-fi
-case $SPC_USE_ARCH in
-current)
-    BASE_ARCH=$(uname -m)
-    if [ "$BASE_ARCH" = "arm64" ]; then
-        BASE_ARCH=aarch64
-        GO_ARCH=arm64
-    else
-        GO_ARCH=amd64
-    fi
-    ;;
-aarch64)
-    BASE_ARCH=aarch64
-    GO_ARCH=arm64
-    # shellcheck disable=SC2039
-    echo -e "\e[033m* Using different arch needs to setup qemu-static for docker !\e[0m"
-    $DOCKER_EXECUTABLE run --rm --privileged multiarch/qemu-user-static:register --reset > /dev/null
-    ;;
-*)
-    echo "Current arch is not supported to run in docker: $SPC_USE_ARCH"
-    exit 1
-    ;;
-esac
-
-# Detect docker env is setup
-if ! $DOCKER_EXECUTABLE images | grep -q cwcc-frankenphp-gnu-$SPC_USE_ARCH; then
-    echo "Docker container does not exist. Building docker image ..."
-    $DOCKER_EXECUTABLE build -t cwcc-frankenphp-gnu-$SPC_USE_ARCH -f- . <<EOF
-FROM centos:7
-RUN sed -i 's/mirror.centos.org/vault.centos.org/g' /etc/yum.repos.d/*.repo && \
-    sed -i 's/^#.*baseurl=http/baseurl=http/g' /etc/yum.repos.d/*.repo && \
-    sed -i 's/^mirrorlist=http/#mirrorlist=http/g' /etc/yum.repos.d/*.repo
-RUN yum clean all && \
-    yum makecache && \
-    yum update -y && \
-    localedef -c -i en_US -f UTF-8 en_US.UTF-8
-
-RUN yum install -y centos-release-scl
-
-RUN if [ "$BASE_ARCH" = "aarch64" ]; then \
-        sed -i 's|mirror.centos.org/centos|vault.centos.org/altarch|g' /etc/yum.repos.d/CentOS-SCLo-scl-rh.repo ; \
-        sed -i 's|mirror.centos.org/centos|vault.centos.org/altarch|g' /etc/yum.repos.d/CentOS-SCLo-scl.repo ; \
-    else \
-        sed -i 's/mirror.centos.org/vault.centos.org/g' /etc/yum.repos.d/*.repo ; \
-    fi
-RUN sed -i 's/^#.*baseurl=http/baseurl=http/g' /etc/yum.repos.d/*.repo && \
-    sed -i 's/^mirrorlist=http/#mirrorlist=http/g' /etc/yum.repos.d/*.repo
-
-RUN yum update -y && \
-    yum install -y devtoolset-10-gcc-*
-RUN echo "source scl_source enable devtoolset-10" >> /etc/bashrc
-RUN source /etc/bashrc
-
-RUN curl -o cmake.tgz -fsSL https://github.com/Kitware/CMake/releases/download/v3.31.4/cmake-3.31.4-linux-$BASE_ARCH.tar.gz && \
-    mkdir /cmake && \
-    tar -xzf cmake.tgz -C /cmake --strip-components 1
-
-WORKDIR /app
-ADD ./src /app/src
-COPY ./composer.* /app/
-ADD ./bin/setup-runtime /app/bin/setup-runtime
-ADD ./bin/spc /app/bin/spc
-RUN /app/bin/setup-runtime
-RUN /app/bin/php /app/bin/composer install --no-dev --classmap-authoritative
-ENV PATH="/app/bin:/cmake/bin:/usr/local/go/bin:$PATH"
-ENV SPC_LIBC=glibc
-
-ADD ./config/env.ini /app/config/env.ini
-RUN bin/spc doctor --auto-fix --debug
-
-RUN curl -o make.tgz -fsSL https://ftp.gnu.org/gnu/make/make-4.4.tar.gz && \
-    tar -zxvf make.tgz && \
-    cd make-4.4 && \
-    ./configure && \
-    make && \
-    make install && \
-    ln -sf /usr/local/bin/make /usr/bin/make
-
-RUN curl -o automake.tgz -fsSL https://ftp.gnu.org/gnu/automake/automake-1.17.tar.xz && \
-    tar -xvf automake.tgz && \
-    cd automake-1.17 && \
-    ./configure && \
-    make && \
-    make install && \
-    ln -sf /usr/local/bin/automake /usr/bin/automake
-
-RUN git clone https://github.com/static-php/gnu-frankenphp --depth=1 /frankenphp
-WORKDIR /frankenphp
-
-RUN curl -o go.tgz -fsSL https://go.dev/dl/go1.24.1.linux-$GO_ARCH.tar.gz && \
-    rm -rf /usr/local/go && tar -C /usr/local -xzf go.tgz
-EOF
-fi
-
-# Check if in ci (local terminal can execute with -it)
-if [ -t 0 ]; then
-    INTERACT=-it
-else
-    INTERACT=''
-fi
-
-# Mounting volumes
-MOUNT_LIST=""
-# shellcheck disable=SC2089
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/config:/app/config"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/src:/app/src"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/buildroot:/app/buildroot"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/source:/app/source"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/dist:/app/dist"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/downloads:/app/downloads"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/pkgroot:/app/pkgroot"
-MOUNT_LIST="$MOUNT_LIST -v ""$(pwd)""/frankenphp-dist:/frankenphp/dist"
-
-# Apply env in temp env file
-echo 'CC=/opt/rh/devtoolset-10/root/usr/bin/gcc' > /tmp/spc-gnu-docker.env
-echo 'CXX=/opt/rh/devtoolset-10/root/usr/bin/g++' >> /tmp/spc-gnu-docker.env
-echo 'AR=/opt/rh/devtoolset-10/root/usr/bin/ar' >> /tmp/spc-gnu-docker.env
-echo 'LD=/opt/rh/devtoolset-10/root/usr/bin/ld' >> /tmp/spc-gnu-docker.env
-echo 'SPC_DEFAULT_C_FLAGS=-fPIE -fPIC' >> /tmp/spc-gnu-docker.env
-echo 'SPC_LIBC=glibc' >> /tmp/spc-gnu-docker.env
-echo 'SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS_PROGRAM="-Wl,-O1 -pie"' >> /tmp/spc-gnu-docker.env
-echo 'SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS="-ldl -lpthread -lm -lresolv -lutil -lrt"' >> /tmp/spc-gnu-docker.env
-
-# Run docker
-# shellcheck disable=SC2068
-# shellcheck disable=SC2086
-# shellcheck disable=SC2090
-
-$DOCKER_EXECUTABLE run --rm $INTERACT -e SPC_FIX_DEPLOY_ROOT="$(pwd)" --env-file /tmp/spc-gnu-docker.env $MOUNT_LIST cwcc-frankenphp-gnu-$SPC_USE_ARCH ./build-static.sh

bin/spc-gnu-docker

@@ -156,7 +156,6 @@ fi
 echo 'SPC_DEFAULT_C_FLAGS=-fPIC' > /tmp/spc-gnu-docker.env
 echo 'SPC_LIBC=glibc' >> /tmp/spc-gnu-docker.env
 echo 'SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS_PROGRAM="-Wl,-O1 -pie"' >> /tmp/spc-gnu-docker.env
-echo 'SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS="-ldl -lpthread -lm -lresolv -lutil -lrt"' >> /tmp/spc-gnu-docker.env
 
 # Environment variable passthrough
 ENV_LIST=""

config/env.ini

@@ -115,12 +115,8 @@ SPC_CMD_VAR_PHP_CONFIGURE_CFLAGS="${SPC_DEFAULT_C_FLAGS} -fPIE"
 SPC_CMD_VAR_PHP_CONFIGURE_CPPFLAGS="-I${BUILD_INCLUDE_PATH}"
 ; LDFLAGS for configuring php
 SPC_CMD_VAR_PHP_CONFIGURE_LDFLAGS="-L${BUILD_LIB_PATH}"
-; LIBS for configuring php
-SPC_CMD_VAR_PHP_CONFIGURE_LIBS="-ldl -lrt -lpthread -lm -lresolv -lutil"
 ; EXTRA_CFLAGS for `make` php
 SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS="-g -fstack-protector-strong -fno-ident -fPIE ${SPC_DEFAULT_C_FLAGS}"
-; EXTRA_LIBS for `make` php
-SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS="-ldl -lrt -lpthread -lm -lresolv -lutil"
 ; EXTRA_LDFLAGS for `make` php, can use -release to set a soname for libphp.so
 SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS=""
 ; EXTRA_LDFLAGS_PROGRAM for `make` php
@@ -158,8 +154,6 @@ SPC_CMD_VAR_PHP_CONFIGURE_CPPFLAGS="-I${BUILD_INCLUDE_PATH}"
 SPC_CMD_VAR_PHP_CONFIGURE_LDFLAGS="-L${BUILD_LIB_PATH}"
 ; EXTRA_CFLAGS for `make` php
 SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS="-g -fstack-protector-strong -fpic -fpie ${SPC_DEFAULT_C_FLAGS}"
-; EXTRA_LIBS for `make` php
-SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS="-lresolv"
 ; embed type for php, static (libphp.a) or shared (libphp.dylib)
 SPC_CMD_VAR_PHP_EMBED_TYPE="static"
 

src/SPC/builder/Extension.php

@@ -405,7 +405,7 @@ class Extension
             'LDFLAGS' => $config['ldflags'],
             'LIBS' => $preStatic . $staticLibString . $postStatic . $sharedLibString,
             'LD_LIBRARY_PATH' => BUILD_LIB_PATH,
-            'COMPILER_EXTRA' => '-lstdc++',
+            'SPC_COMPILER_EXTRA' => '-lstdc++',
         ];
 
         if ($this->patchBeforeSharedPhpize()) {

src/SPC/builder/linux/LinuxBuilder.php

@@ -32,7 +32,7 @@ class LinuxBuilder extends UnixBuilderBase
         GlobalEnvManager::afterInit();
 
         // concurrency
-        $this->concurrency = intval(getenv('SPC_CONCURRENCY'));
+        $this->concurrency = (int) getenv('SPC_CONCURRENCY');
         // cflags
         $this->arch_c_flags = getenv('SPC_DEFAULT_C_FLAGS');
         $this->arch_cxx_flags = getenv('SPC_DEFAULT_CXX_FLAGS');
@@ -94,7 +94,7 @@ class LinuxBuilder extends UnixBuilderBase
         }
         $disable_jit = $this->getOption('disable-opcache-jit', false) ? '--disable-opcache-jit ' : '';
         if (!$disable_jit && $this->getExt('opcache')) {
-            f_putenv('COMPILER_EXTRA=-fno-sanitize=undefined');
+            f_putenv('SPC_COMPILER_EXTRA=-fno-sanitize=undefined');
         }
         $config_file_path = $this->getOption('with-config-file-path', false) ?
             ('--with-config-file-path=' . $this->getOption('with-config-file-path') . ' ') : '';
@@ -113,7 +113,7 @@ class LinuxBuilder extends UnixBuilderBase
             'CFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_CFLAGS'),
             'CPPFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_CPPFLAGS'),
             'LDFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_LDFLAGS'),
-            'LIBS' => $mimallocLibs . getenv('SPC_CMD_VAR_PHP_CONFIGURE_LIBS'),
+            'LIBS' => $mimallocLibs . SPCTarget::getRuntimeLibs(),
         ]);
 
         // process micro upx patch if micro sapi enabled
@@ -336,7 +336,7 @@ class LinuxBuilder extends UnixBuilderBase
     {
         return [
             'EXTRA_CFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS'),
-            'EXTRA_LIBS' => getenv('SPC_EXTRA_LIBS') . ' ' . getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS'),
+            'EXTRA_LIBS' => getenv('SPC_EXTRA_LIBS') . ' ' . SPCTarget::getRuntimeLibs(),
             'EXTRA_LDFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS'),
             'EXTRA_LDFLAGS_PROGRAM' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LDFLAGS_PROGRAM'),
         ];

src/SPC/builder/macos/MacOSBuilder.php

@@ -12,6 +12,7 @@ use SPC\exception\WrongUsageException;
 use SPC\store\FileSystem;
 use SPC\store\SourcePatcher;
 use SPC\util\GlobalEnvManager;
+use SPC\util\SPCTarget;
 
 class MacOSBuilder extends UnixBuilderBase
 {
@@ -33,7 +34,7 @@ class MacOSBuilder extends UnixBuilderBase
 
         // ---------- set necessary compile vars ----------
         // concurrency
-        $this->concurrency = intval(getenv('SPC_CONCURRENCY'));
+        $this->concurrency = (int) getenv('SPC_CONCURRENCY');
         // cflags
         $this->arch_c_flags = getenv('SPC_DEFAULT_C_FLAGS');
         $this->arch_cxx_flags = getenv('SPC_DEFAULT_CXX_FLAGS');
@@ -131,7 +132,7 @@ class MacOSBuilder extends UnixBuilderBase
             'CFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_CFLAGS'),
             'CPPFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_CPPFLAGS'),
             'LDFLAGS' => getenv('SPC_CMD_VAR_PHP_CONFIGURE_LDFLAGS'),
-            'LIBS' => $mimallocLibs . getenv('SPC_CMD_VAR_PHP_CONFIGURE_LIBS'),
+            'LIBS' => $mimallocLibs . SPCTarget::getRuntimeLibs(),
         ]);
 
         if ($this->getLib('postgresql')) {
@@ -293,7 +294,7 @@ class MacOSBuilder extends UnixBuilderBase
     {
         return [
             'EXTRA_CFLAGS' => getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS'),
-            'EXTRA_LIBS' => getenv('SPC_EXTRA_LIBS') . ' ' . getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS'),
+            'EXTRA_LIBS' => getenv('SPC_EXTRA_LIBS') . ' ' . SPCTarget::getRuntimeLibs(),
         ];
     }
 }

src/SPC/builder/unix/library/libaom.php

@@ -12,16 +12,16 @@ trait libaom
 {
     protected function build(): void
     {
-        $extra = getenv('COMPILER_EXTRA');
+        $extra = getenv('SPC_COMPILER_EXTRA');
         if (ToolchainManager::getToolchainClass() === ZigToolchain::class) {
             $new = trim($extra . ' -D_GNU_SOURCE');
-            f_putenv("COMPILER_EXTRA={$new}");
+            f_putenv("SPC_COMPILER_EXTRA={$new}");
         }
         UnixCMakeExecutor::create($this)
             ->setBuildDir("{$this->source_dir}/builddir")
             ->addConfigureArgs('-DAOM_TARGET_CPU=generic')
             ->build();
-        f_putenv("COMPILER_EXTRA={$extra}");
+        f_putenv("SPC_COMPILER_EXTRA={$extra}");
         $this->patchPkgconfPrefix(['aom.pc']);
     }
 }

src/SPC/builder/windows/WindowsBuilder.php

@@ -45,7 +45,7 @@ class WindowsBuilder extends BuilderBase
         $this->zts = $this->getOption('enable-zts', false);
 
         // set concurrency
-        $this->concurrency = intval(getenv('SPC_CONCURRENCY'));
+        $this->concurrency = (int) getenv('SPC_CONCURRENCY');
 
         // make cmake toolchain
         $this->cmake_toolchain_file = SystemUtil::makeCmakeToolchainFile();

src/SPC/store/scripts/zig-cc.sh

@@ -29,7 +29,7 @@ done
 [[ -n "$SPC_TARGET" ]] && TARGET="-target $SPC_TARGET" || TARGET=""
 
 if [[ "$SPC_TARGET" =~ \.[0-9]+\.[0-9]+ ]]; then
-    output=$(zig cc $TARGET $COMPILER_EXTRA "${PARSED_ARGS[@]}" 2>&1)
+    output=$(zig cc $TARGET $SPC_COMPILER_EXTRA "${PARSED_ARGS[@]}" 2>&1)
     status=$?
 
     if [[ $status -eq 0 ]]; then
@@ -44,4 +44,4 @@ if [[ "$SPC_TARGET" =~ \.[0-9]+\.[0-9]+ ]]; then
     fi
 fi
 
-exec zig cc $TARGET $COMPILER_EXTRA "${PARSED_ARGS[@]}"
+exec zig cc $TARGET $SPC_COMPILER_EXTRA "${PARSED_ARGS[@]}"

src/SPC/util/SPCConfigUtil.php

@@ -64,9 +64,8 @@ class SPCConfigUtil
 
         // embed
         $libs = trim("-lphp -lc {$libs}");
-        $extra_env = getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_LIBS');
-        if (is_string($extra_env)) {
-            $libs .= ' ' . trim($extra_env, '"');
+        if ($extra_libs = SPCTarget::getRuntimeLibs()) {
+            $libs .= " {$extra_libs}";
         }
         // c++
         if ($this->builder->hasCpp()) {

src/SPC/util/SPCTarget.php

@@ -74,6 +74,17 @@ class SPCTarget
         return null;
     }
 
+    public static function getRuntimeLibs(): string
+    {
+        if (PHP_OS_FAMILY === 'Linux') {
+            return self::getLibc() === 'musl' ? 'ldl -lpthread -lm' : '-ldl -lrt -lpthread -lm -lresolv -lutil';
+        }
+        if (PHP_OS_FAMILY === 'Darwin') {
+            return '-lresolv';
+        }
+        return '';
+    }
+
     /**
      * Returns the libc version if set, for other OS, it will always return null.
      */