dir separator and typo fix [skip ci]

This commit is contained in:
crazywhalecc 2023-12-24 13:07:51 +08:00
parent 31f6fb17bf
commit 5a98bd6656
2 changed files with 4 additions and 3 deletions

View File

@ -16,12 +16,13 @@ class WindowsToolCheckList
public function checkGit(): ?CheckResult public function checkGit(): ?CheckResult
{ {
if (SystemUtil::findCommand('git.exe') === null) { if (SystemUtil::findCommand('git.exe') === null) {
return CheckResult::fail('Git not installed, see https://static-php.dev/en/guide/windows-setup.html'); return CheckResult::fail('Git not installed, please install git for windows manually, see: https://git-scm.com/download/win');
// return CheckResult::fail('Git not installed, see https://static-php.dev/en/guide/windows-setup.html');
} }
return CheckResult::ok(); return CheckResult::ok();
} }
#[AsCheckItem('if php-sdk-binary-tools2 are downloaded', limit_os: 'Windows', level: 998)] #[AsCheckItem('if php-sdk-binary-tools are downloaded', limit_os: 'Windows', level: 998)]
public function checkSDK(): ?CheckResult public function checkSDK(): ?CheckResult
{ {
if (!file_exists(PHP_SDK_PATH . DIRECTORY_SEPARATOR . 'phpsdk-starter.bat')) { if (!file_exists(PHP_SDK_PATH . DIRECTORY_SEPARATOR . 'phpsdk-starter.bat')) {

View File

@ -23,7 +23,7 @@ define('SEPARATED_PATH', [
]); ]);
if (PHP_OS_FAMILY === 'Windows') { if (PHP_OS_FAMILY === 'Windows') {
define('PHP_SDK_PATH', is_string($a = getenv('PHP_SDK_PATH')) ? $a : (WORKING_DIR . '/php-sdk-binary-tools')); define('PHP_SDK_PATH', is_string($a = getenv('PHP_SDK_PATH')) ? $a : (WORKING_DIR . DIRECTORY_SEPARATOR . 'php-sdk-binary-tools'));
} }
// dangerous command // dangerous command