crazywhalecc/static-php-cli
1
0
Fork 0
mirror of https://github.com/crazywhalecc/static-php-cli.git synced 2026-07-08 17:35:36 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Marc <m@pyc.ac>
This commit is contained in:
Marc
2026-04-09 14:00:10 +07:00
committed by GitHub
parent 4d2036f20e
commit fb7730989c
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/SPC/builder/extension/xlswriter.php
View File

@@ -30,7 +30,7 @@ class xlswriter extends Extension
{ {
$patched = parent::patchBeforeMake(); $patched = parent::patchBeforeMake();
// Bundled minizip uses K&R C function declarations rejected by C23 (default on macOS with Xcode 16+) // Remove when https://github.com/viest/php-ext-xlswriter/pull/560 is merged
if (PHP_OS_FAMILY !== 'Windows') { if (PHP_OS_FAMILY !== 'Windows') {
GlobalEnvManager::putenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS=' . getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS') . ' -std=gnu17'); GlobalEnvManager::putenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS=' . getenv('SPC_CMD_VAR_PHP_MAKE_EXTRA_CFLAGS') . ' -std=gnu17');
$patched = true; $patched = true;
@@ -49,6 +49,7 @@ class xlswriter extends Extension
return $patched; return $patched;
} }
// Remove when https://github.com/viest/php-ext-xlswriter/pull/560 is merged
protected function getExtraEnv(): array protected function getExtraEnv(): array
{ {
return ['CFLAGS' => '-std=gnu17']; return ['CFLAGS' => '-std=gnu17'];